docs: use "length" over "len" in tutorial3 python #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcamise-gpsw , first of all thank you for maintaining this repository. This is a simple Pull Request, when I was reading through the tutorials I noticed this mismatch between the variable names in the docs and those in the tutorial (demo). The CI seems to be failing on the "Pre Merge Checks", if there is something I need to do on my end let me know. Feel free to close or amend yourself. Once again, thank you for maintaining this and I hope to see GoPro get more involved in OSS. |
tcamise-gpsw
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edit the occurrence of "len" to "length" since the
ble_command_get_version.pythat is being referenced uses "length".See permalink:
OpenGoPro/demos/python/tutorial/tutorial_modules/tutorial_3_parse_ble_tlv_responses/ble_command_get_version.py
Line 40 in f36409a